-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many Nightly Fixes #2376
Many Nightly Fixes #2376
Conversation
2c1bd2d
to
1c36df1
Compare
03a1ace
to
4299754
Compare
@weiznich I think this should be good now, and ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good modulo that new feature flag for diesel_migrations
. If we really need to do something like that we should go with a raw --cfg "fix_for_whatever"
flag, so that we do not introduce a new feature flag in our public API.
4299754
to
c3ef454
Compare
c3ef454
to
a19c6e3
Compare
@weiznich I think I addressed all the concerns by updating :) |
Update to nightly that has clippy and rustfmt
Fix nightly builds rust-lang/rust#70814
Fix an intra doc link for diesel as a dev-dependency